Skip to content

Conversation

pascalbaljet
Copy link
Member

@pascalbaljet pascalbaljet commented Oct 16, 2025

This PR unifies the types around cancel tokens. Previously, we had a mixed bag of implementations.

import type { CancelTokenSource } from 'axios'

type VisitCallbacks = {
  // Core adapter...
  onCancelToken: { ({ cancel }: { cancel: VoidFunction }): void },

  // Svelte adapter...
  oncanceltoken?: (event: CustomEvent<CancelTokenSource>) => void
}

// Vue adapter...
defineProps({
  onCancelToken: {
    type: Function as PropType<(cancelToken: import('axios').CancelTokenSource) => void>,
  }
})

We now have unified internal types in the core package. These are used across all adapters without any dependency on Axios types.

This was originally planned in PR #2549, but I decided to split it up into multiple PRs for clarity.

@pascalbaljet pascalbaljet changed the title Introduce CancelToken and CancelTokenCallback types in favor of Axios imports Introduce CancelToken and CancelTokenCallback types to replace Axios imports Oct 16, 2025
@pascalbaljet pascalbaljet marked this pull request as ready for review October 16, 2025 12:23
@pascalbaljet pascalbaljet merged commit a59a7c5 into master Oct 16, 2025
12 checks passed
@pascalbaljet pascalbaljet deleted the unify-cancel-token-types branch October 16, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant